Dynamic root with culture and segment #15287
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)
succeeded
Nov 22, 2023 in 51s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Primitive Obsession EntityController.cs
Annotations
Check notice on line 1 in src/Umbraco.Web.BackOffice/Controllers/EntityController.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1141 to 1145, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 144 in src/Umbraco.Web.BackOffice/Controllers/EntityController.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
ℹ Getting worse: Constructor Over-Injection
EntityController increases from 21 to 22 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 1 in src/Umbraco.Web.BackOffice/Controllers/EntityController.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 40.61% to 40.36%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Loading