Fix IWebhook.GetUdi()
and IEntity.GetUdi()
extension methods
#15288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Although PR #15267 includes most of the boilerplate code to make
Webhook
implementIEntity
, theGetUdi()
extension method wasn't updated to use the interface and theIEntity.GetUdi()
extension method didn't support the webhook entity type. This PR fixes both of these issues in the first commit.I've also taken the opportunity to refactor the code in the second commit, so it's much more compact and readable by using:
ArgumentNullException.ThrowIfNull()
for all null checks (although we're already in a nullable context);switch
expressions, which also takes care of detecting unreachable code, in case multiple types would match (e.g.IContent
andIContentBase
).Finally, I've also added a quick unit test to verify the
GetUdi()
extension methods do what they should 😄