Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V13: Delivery API composite id handler #15305

Merged
merged 5 commits into from
Nov 29, 2023
Merged

V13: Delivery API composite id handler #15305

merged 5 commits into from
Nov 29, 2023

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Nov 28, 2023

Notes

  • Implement IDeliveryApiCompositeIdHandler
  • Refactor DeliveryApiContentIndex & DeliveryApiContentIndexHandleContentTypeChanges to use IDeliveryApiCompositeIdHandler.

How to test

  • Add a language so you have atleast 2 languages
  • Create a document type with allow vary by culture set to true.
  • Create a document in both languages.
  • Go to settings -> Examine management -> DeliveryApiContentIndex.
  • Search for the document you created
  • You should see the same __NodeId as in v13/dev:

image

@Zeegaan Zeegaan changed the base branch from v13/dev to release/13.0 November 28, 2023 12:01
kjac
kjac approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and tests out great too 💪

@Zeegaan Zeegaan merged commit a8dc058 into release/13.0 Nov 29, 2023
15 checks passed
@Zeegaan Zeegaan deleted the v13/feature/composite-id-handler branch November 29, 2023 13:10
@elit0451 elit0451 mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjac kjac kjac approved these changes

Assignees
No one assigned
Labels
release/13.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeegaan @kjac