Do not dispose EF Core contexts manually #15649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Ef core context is protected from creations when no connection string is present. If it changes that single instance will continue with the connection string it was initialized with.
…string-and-only-dispose-if-it-have-been-updated' into v13/bugfix/15090-save-connectionstring-and-only-dispose-if-it-have-been-updated # Conflicts: # src/Umbraco.Cms.Persistence.EFCore/UmbracoDbContext.cs
bergmania
deleted the
v13/bugfix/15090-save-connectionstring-and-only-dispose-if-it-have-been-updated
branch
bergmania
added a commit
that referenced
this pull request
Jan 31, 2024
* Attempt to fix #15090. Save connection string in private variable after setup. * Do not dispose ef core contexts when if the connectionstring changes. A Ef core context is protected from creations when no connection string is present. If it changes that single instance will continue with the connection string it was initialized with. * Clean up * Review Equals methods (cherry picked from commit 5146f05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR that removes the functionality that disposes a EF Core context when the connection string changes.
Fixes: #15090 (Again)
Background
Some people still have timing issues when installing, because the EF Core context is disposed.
The reason is because
IOptionsMonitorcan call theOnChangeevent even that it have read the correct value some time before.So the timing issue happens, if the
UmbracoDbContextis constructed just after the connection string is updated in the json file. Then the constructor reads the updated value, but afterwards the onChange is called, even that it did not really change anything (Since the creation).We should be safe, because an earlier PR throws an exception from the constructor, if the connection string do not exists.
After this PR,
UmbracoDbContextinitialised with a connection string will continue to work with that connection string until disposed.