Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making method ExecuteAsync virtual #16496

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

PeterKvayt
Copy link
Contributor

@PeterKvayt PeterKvayt commented May 29, 2024

This pr is intended to implement the following feature request: 16495

I really want this methods described in 16495 become virtual in umbraco 10

Copy link

github-actions bot commented May 29, 2024

Hi there @PeterKvayt, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @PeterKvayt, thanks a lot for your PR to fix #16495, someone on the core collaborators team will review this soon 😄

@emmagarland emmagarland self-assigned this Aug 13, 2024
@emmagarland emmagarland merged commit 3a9ef38 into umbraco:contrib Aug 14, 2024
12 of 14 checks passed
@emmagarland
Copy link
Contributor

Hi @PeterKvayt

Thanks for your PR to implement #16495, to make the ExecuteAsync method virtual. I've checked with HQ and this change is good to go in so I've merged it 👍 We will look into backporting it where relevant.

It also looks like this is your first PR to this repository! Nice work! #H5YR 🎉

If have an account on our.umbraco.com please feel free to drop a comment below with your account name.

@nul800sebastiaan or one of the team will add you a lovely new C-Trib badge to your profile. 🏅

Cheers!

Emma

nul800sebastiaan pushed a commit that referenced this pull request Aug 15, 2024
Co-authored-by: Kvyatkovsky, Petr <pkvyatkovsky@qulix.com>
(cherry picked from commit 3a9ef38)
@nul800sebastiaan
Copy link
Member

nul800sebastiaan commented Aug 15, 2024

Cherry-picked for v13 in bb1c36f

Congrats on your contributor badge! 👍 https://our.umbraco.com/members/PeterKvayt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants