-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making method ExecuteAsync virtual #16496
Conversation
Hi there @PeterKvayt, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey @PeterKvayt, thanks a lot for your PR to fix #16495, someone on the core collaborators team will review this soon 😄 |
Hi @PeterKvayt Thanks for your PR to implement #16495, to make the It also looks like this is your first PR to this repository! Nice work! #H5YR 🎉 If have an account on our.umbraco.com please feel free to drop a comment below with your account name. @nul800sebastiaan or one of the team will add you a lovely new Cheers! Emma |
Co-authored-by: Kvyatkovsky, Petr <pkvyatkovsky@qulix.com> (cherry picked from commit 3a9ef38)
Cherry-picked for v13 in bb1c36f Congrats on your contributor badge! 👍 https://our.umbraco.com/members/PeterKvayt |
This pr is intended to implement the following feature request: 16495
I really want this methods described in 16495 become virtual in umbraco 10