Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAsyncComponent to allow async initialize/terminate #16536

Merged
merged 4 commits into from
Sep 23, 2024

Add AsyncComponentBase and RuntimeAsyncComponentBase

31b267e
Select commit
Loading
Failed to load commit list.
Merged

Add IAsyncComponent to allow async initialize/terminate #16536

Add AsyncComponentBase and RuntimeAsyncComponentBase
31b267e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) succeeded Jun 2, 2024 in 35s

CodeScene PR Check

Code Health Quality Gates: OK

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Overall Code Complexity ObjectExtensions.cs

Annotations

Check notice on line 1 in src/Umbraco.Core/Extensions/ObjectExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 7.24 to 7.00, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 1 in src/Umbraco.Core/Extensions/ObjectExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

ℹ Getting worse: Primitive Obsession

The ratio of primitive types in function arguments increases from 58.33% to 59.46%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.