Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14 QA Fixed DocumentType and MediaType tests #16539

Merged
merged 5 commits into from
Jun 7, 2024
Merged

V14 QA Fixed DocumentType and MediaType tests #16539

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2c4137
Changed name of locator click
andr317c Jun 3, 2024
7a478a4
fixed tests
andr317c Jun 3, 2024
fd87592
Bumped version of testHelpers
andr317c Jun 5, 2024
434fdd0
Merge branch 'v14/dev' into v14/QA/fix-document-type-test
andr317c Jun 5, 2024
7ac85c8
Update tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Setting…
andr317c Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/Umbraco.Tests.AcceptanceTest/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/Umbraco.Tests.AcceptanceTest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"dependencies": {
"@umbraco/json-models-builders": "^2.0.5",
"@umbraco/playwright-testhelpers": "^2.0.0-beta.57",
"@umbraco/playwright-testhelpers": "^2.0.0-beta.58",
"camelize": "^1.0.0",
"dotenv": "^16.3.1",
"faker": "^4.1.0",
Expand Down
5 changes: 3 additions & 2 deletions ...ts.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ test('can create a document type with a composition', {tag: '@smoke'}, async ({u
await umbracoApi.documentType.ensureNameNotExists(compositionDocumentTypeName);
});

test('can remove a composition form a document type', async ({umbracoApi, umbracoUi}) => {
test('can remove a composition form a document type', async ({page, umbracoApi, umbracoUi}) => {
andr317c marked this conversation as resolved.
Show resolved Hide resolved
// Arrange
const compositionDocumentTypeName = 'CompositionDocumentType';
await umbracoApi.documentType.ensureNameNotExists(compositionDocumentTypeName);
Expand All @@ -243,6 +243,7 @@ test('can remove a composition form a document type', async ({umbracoApi, umbrac
await umbracoUi.documentType.clickCompositionsButton();
await umbracoUi.documentType.clickButtonWithName(compositionDocumentTypeName);
await umbracoUi.documentType.clickSubmitButton();
await umbracoUi.documentType.clickConfirmToSubmitButton();
await umbracoUi.documentType.clickSaveButton();

// Assert
Expand Down Expand Up @@ -420,7 +421,7 @@ test('can set appearance to label on top for a property in a document type', asy
// Act
await umbracoUi.documentType.goToDocumentType(documentTypeName);
await umbracoUi.documentType.clickEditorSettingsButton();
await umbracoUi.documentType.clickLabelOnTopButton();
await umbracoUi.documentType.clickLabelAboveButton();
await umbracoUi.documentType.clickUpdateButton();
await umbracoUi.documentType.clickSaveButton();

Expand Down
2 changes: 1 addition & 1 deletion ...co.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeDesignTab.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ test('can set appearance as label on top for property in a media type', async ({
// Act
await umbracoUi.mediaType.goToMediaType(mediaTypeName);
await umbracoUi.mediaType.clickEditorSettingsButton();
await umbracoUi.mediaType.clickLabelOnTopButton();
await umbracoUi.mediaType.clickLabelAboveButton();
await umbracoUi.mediaType.clickUpdateButton();
await umbracoUi.mediaType.clickSaveButton();

Expand Down
Loading