Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenIddict should only handle /umbraco/ requests #16549

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Jun 4, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

OpenIddict performs initial request context processing for every last request to the server - including front-end requests. While this handling is not terribly costly, there really is no reason for it unless a /umbraco/ request is in progress.

Testing this PR

  1. First and foremost, the backoffice should work as per usual 😄
  2. Enable verbose logging and verify that the OpenIddict request processing is only invoked for /umbraco/ requests.
  3. Setup member auth for the Delivery API and verify that this still works.

Particularly the last point is a little tricky to get right. Get in touch with @kjac for a pair testing session 👍

Copy link
Member

@bergmania bergmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests out great 💪

@bergmania bergmania merged commit a64dbe1 into v14/dev Jun 10, 2024
16 checks passed
@bergmania bergmania deleted the v14/feature/openiddict-performance-improvement branch June 10, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants