-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Update to dotnet 9 #16625
V15: Update to dotnet 9 #16625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have a look at the pipelines and update the <TargetFramework>
to net9.0 in the csproj's of our dotnet new templates? And the .template.config/template.json has also mentions of net8.0
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had a quick look and added my comments/suggestions 😄
Seems like we can actually do more cleaning up of the StringExtensions
class, as there's a lot of unused methods or ones that are very specific to our own codebase and could therefore be changed to internal...
Co-authored-by: Ronald Barendse <ronald@barend.se>
…into v15/feature/update-to-dotnet-9
@ronaldbarendse Cleanup sounds great, but is out of scope for this PR IMO, we can always make a separate one with cleanups 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests out good 💪 Merging
Notes
TrimStart
&TrimEnd
, as they are now implemented by Microsoft, and the behavior differs from ours.Microsoft.CodeAnalysis
package, and thus we couldn't update that.How to test
Ensure both templates & source code work with dotnet 9
dotnet pack -o nuget
cd nuget
dotnet nuget add source [PATH TO NUGET FOLDER HERE]
dotnet new install Umbraco.Templates::[version of templates here]
dotnet new umbraco -n "MyTestProject"