V13: Eaglery route domains for virtual page controllers #16635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeegaan
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Do domain routing eagerly * Cleanup * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16626
This was caused because the
Thread.CurrentThread.CurrentUICultureis set byUmbracoPublishedContentCultureProviderwhich runs before any of the filters, meaning thatCurrentUICulturewas never set correctly, so to fix this I've made theEagerMatcherPolicydetect if it's aUmbracoPageControllerand then do the domain routing and setting a dummyUmbracoRouteValueswhich is then used to assign the correctCurrentUICultureby theUmbracoPublishedContentCultureProvider.