Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Health Check for Runtime mode #16715

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

erikjanwestendorp
Copy link
Contributor

I thought it might be a good idea to add a health check to make sure the runtime mode is set to Production. 😄

image

Copy link

github-actions bot commented Jun 28, 2024

Hi there @erikjanwestendorp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@JasonElkin JasonElkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @erikjanwestendorp - what a good idea!

I think we need to clarify the language a bit so I have added some suggestions but happy to have a discussion if you think it could be clearer.

src/Umbraco.Core/EmbeddedResources/Lang/en.xml Outdated Show resolved Hide resolved
src/Umbraco.Core/EmbeddedResources/Lang/en_us.xml Outdated Show resolved Hide resolved
@JasonElkin JasonElkin self-assigned this Jul 2, 2024
erikjanwestendorp and others added 3 commits July 2, 2024 15:58
Co-authored-by: Jason Elkin <jasonelkin86@gmail.com>
…deCheck.cs

Co-authored-by: Jason Elkin <jasonelkin86@gmail.com>
@erikjanwestendorp
Copy link
Contributor Author

@JasonElkin Thanks for the review and your suggestions. Just updated the PR 😄

@JasonElkin
Copy link
Contributor

Just a note to say that the build failing is an issue with the contrib branch, not this PR.

Thanks again for this @erikjanwestendorp, H5YR!

@JasonElkin JasonElkin merged commit 9a49ab7 into umbraco:contrib Jul 24, 2024
3 of 5 checks passed
@erikjanwestendorp erikjanwestendorp deleted the runtime-mode-check branch July 24, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants