-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Health Check for Runtime mode #16715
Add Health Check for Runtime mode #16715
Conversation
Hi there @erikjanwestendorp, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @erikjanwestendorp - what a good idea!
I think we need to clarify the language a bit so I have added some suggestions but happy to have a discussion if you think it could be clearer.
src/Umbraco.Core/HealthChecks/Checks/LiveEnvironment/RuntimeModeCheck.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason Elkin <jasonelkin86@gmail.com>
…deCheck.cs Co-authored-by: Jason Elkin <jasonelkin86@gmail.com>
@JasonElkin Thanks for the review and your suggestions. Just updated the PR 😄 |
Just a note to say that the build failing is an issue with the contrib branch, not this PR. Thanks again for this @erikjanwestendorp, H5YR! |
I thought it might be a good idea to add a health check to make sure the runtime mode is set to Production. 😄