Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make block editor base classes public #16774

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

mattbrailsford
Copy link
Contributor

Prerequisites

If there's an existing issue for this PR then this fixes: #16757

Description

This update makes the block editor base classes public in order to allow for external package developers to also create custom block editors. This is necessary for Umbraco Commerces variants property editor which is also a block based editor.

@iOvergaard iOvergaard requested a review from kjac July 15, 2024 12:44
Change to trigger a new build for umbraco#16774
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💪

@kjac kjac merged commit b14ac81 into umbraco:contrib Jul 26, 2024
14 checks passed
bergmania pushed a commit that referenced this pull request Nov 4, 2024
…PublishedContent.Children` to better alternatives (#17419)

* Make block editor base classes public

* Update BlockEditorValues.cs

Change to trigger a new build for #16774

* Update IPublishedContent.cs

Provide better suggestions for alternatives to `Childrent` and `Parent`

* Updated obsolete message

---------

Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block editor base classes should be public
3 participants