Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13: Tours prevent you from interacting with the Backoffice on first log in #16775

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

iOvergaard
Copy link
Contributor

Description

Fixes #16742

This reverts one of the changes made in #15133, where the inert attribute was added when a Tour is active. This caused a few issues where:

  • The close code was never called for the "email marketing" tour causing Cloud sites to be unresponsive until you refresh
  • The "getting started" tour did not work on the steps, where you are supposed to click a button in the Backoffice UI

I think the inert attribute is useful in some cases where there is no "click-through" in a tour step, but we will have to be more clever about when to place it and when to remove it again.

…be able to work with the background in certain steps
@iOvergaard iOvergaard changed the base branch from v13/dev to release/13.4 July 11, 2024 09:59
@iOvergaard iOvergaard changed the base branch from release/13.4 to v13/dev July 11, 2024 09:59
@nul800sebastiaan
Copy link
Member

Works like a charm! 👍

@nul800sebastiaan nul800sebastiaan merged commit a41555c into v13/dev Jul 11, 2024
16 checks passed
@nul800sebastiaan nul800sebastiaan deleted the v13/bugfix/tour-inert-attribute branch July 11, 2024 10:38
@nul800sebastiaan nul800sebastiaan removed their request for review July 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants