V14 Fixing the failing smoke tests

tests/Umbraco.Tests.AcceptanceTest/package.json

@@ -22,7 +22,7 @@
   },
   "dependencies": {
     "@umbraco/json-models-builders": "^2.0.13",
-    "@umbraco/playwright-testhelpers": "^2.0.0-beta.68",
+    "@umbraco/playwright-testhelpers": "^2.0.0-beta.70",
     "camelize": "^1.0.0",
     "dotenv": "^16.3.1",
     "faker": "^4.1.0",

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/Members.spec.ts

@@ -106,8 +106,8 @@ test('can edit password', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
   // Act
   await umbracoUi.member.clickMemberLinkByName(memberName);
   await umbracoUi.member.clickChangePasswordButton();
-  await umbracoUi.member.enterNewPassword(updatedPassword);
-  await umbracoUi.member.enterConfirmPassword(updatedPassword);
+  await umbracoUi.member.enterPassword(updatedPassword);
+  await umbracoUi.member.enterConfirmNewPassword(updatedPassword);
   await umbracoUi.member.clickSaveButton();
 
   // Assert
@@ -173,9 +173,16 @@ test('can view member info', async ({umbracoApi, umbracoUi}) => {
   // Assert
   const memberData = await umbracoApi.member.get(memberId);
   await umbracoUi.member.doesMemberInfoHaveValue('Failed login attempts', memberData.failedPasswordAttempts.toString());
-  await umbracoUi.member.doesMemberInfoHaveValue('Last lockout date', memberData.lastLoginDate == null ? 'never' : memberData.lastLoginDate);
-  await umbracoUi.member.doesMemberInfoHaveValue('Last login', memberData.lastLoginDate == null ? 'never' : memberData.lastLoginDate);
-  await umbracoUi.member.doesMemberInfoHaveValue('Password changed', new Date(memberData.lastPasswordChangeDate).toLocaleString());
+  await umbracoUi.member.doesMemberInfoHaveValue('Last lockout date', memberData.lastLoginDate == null ? 'Never' : memberData.lastLoginDate);
+  await umbracoUi.member.doesMemberInfoHaveValue('Last login', memberData.lastLoginDate == null ? 'Never' : memberData.lastLoginDate);
+  await umbracoUi.member.doesMemberInfoHaveValue('Password changed', new Date(memberData.lastPasswordChangeDate).toLocaleString("en-US", {
+    year: "numeric",
+    month: "long",
+    day: "numeric",
+    hour: "numeric",
+    minute: "numeric",
+    hour12: true,
+  }));
 });
 
 test('can enable approved', async ({umbracoApi, umbracoUi}) => {

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeDesignTab.spec.ts

@@ -339,7 +339,7 @@ test('can add a description to a property in a document type', async ({umbracoAp
   await umbracoUi.documentType.goToDocumentType(documentTypeName);
   await umbracoUi.documentType.clickEditorSettingsButton();
   await umbracoUi.documentType.enterPropertyEditorDescription(descriptionText);
-  await umbracoUi.documentType.clickUpdateButton();
+  await umbracoUi.documentType.clickSubmitButton();
   await umbracoUi.documentType.clickSaveButton();
 
   // Assert
@@ -360,7 +360,7 @@ test('can set is mandatory for a property in a document type', {tag: '@smoke'},
   await umbracoUi.documentType.goToDocumentType(documentTypeName);
   await umbracoUi.documentType.clickEditorSettingsButton();
   await umbracoUi.documentType.clickMandatorySlider();
-  await umbracoUi.documentType.clickUpdateButton();
+  await umbracoUi.documentType.clickSubmitButton();
   await umbracoUi.documentType.clickSaveButton();
 
   // Assert
@@ -383,7 +383,7 @@ test('can enable validation for a property in a document type', async ({umbracoA
   await umbracoUi.documentType.selectValidationOption('');
   await umbracoUi.documentType.enterRegEx(regex);
   await umbracoUi.documentType.enterRegExMessage(regexMessage);
-  await umbracoUi.documentType.clickUpdateButton();
+  await umbracoUi.documentType.clickSubmitButton();
   await umbracoUi.documentType.clickSaveButton();
 
   // Assert
@@ -403,7 +403,7 @@ test('can allow vary by culture for a property in a document type', {tag: '@smok
   await umbracoUi.documentType.goToDocumentType(documentTypeName);
   await umbracoUi.documentType.clickEditorSettingsButton();
   await umbracoUi.documentType.clickVaryByCultureSlider();
-  await umbracoUi.documentType.clickUpdateButton();
+  await umbracoUi.documentType.clickSubmitButton();
   await umbracoUi.documentType.clickSaveButton();
 
   // Assert
@@ -422,7 +422,7 @@ test('can set appearance to label on top for a property in a document type', asy
   await umbracoUi.documentType.goToDocumentType(documentTypeName);
   await umbracoUi.documentType.clickEditorSettingsButton();
   await umbracoUi.documentType.clickLabelAboveButton();
-  await umbracoUi.documentType.clickUpdateButton();
+  await umbracoUi.documentType.clickSubmitButton();
   await umbracoUi.documentType.clickSaveButton();
 
   // Assert

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Language/Language.spec.ts

@@ -15,34 +15,36 @@ test.afterEach(async ({umbracoApi}) => {
   await umbracoApi.language.ensureNameNotExists(languageName);
 });
 
-test.skip('can add language', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
+test('can add language', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
   // Arrange
-  await umbracoUi.language.goToSettingsTreeItem('Language');
+  await umbracoUi.language.goToLanguages();
 
   // Act
   await umbracoUi.language.clickCreateLink();
   await umbracoUi.language.chooseLanguageByName(languageName);
   await umbracoUi.language.clickSaveButton();
 
   // Assert
+  await umbracoUi.language.isSuccessNotificationVisible();
   expect(await umbracoApi.language.doesExist(isoCode)).toBeTruthy();
   // Verify the created language displays in the list
-  await umbracoUi.language.clickLanguageRoot();
+  await umbracoUi.language.clickLanguagesMenu();
   await umbracoUi.language.isLanguageNameVisible(languageName, true);
 });
 
 test('can update default language option', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
   // Arrange
   await umbracoApi.language.create(languageName, false, false, isoCode);
   expect(await umbracoApi.language.doesExist(isoCode)).toBeTruthy();
-  await umbracoUi.language.goToSettingsTreeItem('Language');
+  await umbracoUi.language.goToLanguages();
 
   // Act
   await umbracoUi.language.clickLanguageByName(languageName);
   await umbracoUi.language.switchDefaultLanguageOption();
   await umbracoUi.language.clickSaveButton();
 
   // Assert
+  await umbracoUi.language.isSuccessNotificationVisible();
   const languageData = await umbracoApi.language.get(isoCode);
   expect(languageData.isDefault).toBe(true);
 
@@ -57,14 +59,15 @@ test('can update mandatory language option', async ({umbracoApi, umbracoUi}) =>
   // Arrange
   await umbracoApi.language.create(languageName, false, false, isoCode);
   expect(await umbracoApi.language.doesExist(isoCode)).toBeTruthy();
-  await umbracoUi.language.goToSettingsTreeItem('Language');
+  await umbracoUi.language.goToLanguages();
 
   // Act
   await umbracoUi.language.clickLanguageByName(languageName);
   await umbracoUi.language.switchMandatoryLanguageOption();
   await umbracoUi.language.clickSaveButton();
 
   // Assert
+  await umbracoUi.language.isSuccessNotificationVisible();
   const languageData = await umbracoApi.language.get(isoCode);
   expect(languageData.isMandatory).toBe(true);
 });
@@ -73,49 +76,63 @@ test('can delete language', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) =>
   // Arrange
   await umbracoApi.language.create(languageName, false, false, isoCode);
   expect(await umbracoApi.language.doesExist(isoCode)).toBeTruthy();
-  await umbracoUi.language.goToSettingsTreeItem('Language');
+  await umbracoUi.language.goToLanguages();
 
   // Act
   await umbracoUi.language.removeLanguageByName(languageName);
 
   // Assert
   await umbracoUi.language.isSuccessNotificationVisible();
   expect(await umbracoApi.language.doesExist(isoCode)).toBeFalsy();
-  // TODO: uncomment this when the front-end is ready. Currently the deleted language is not disappeared after deleting.
-  //await umbracoUi.language.isLanguageNameVisible(languageName, false);
+  await umbracoUi.language.isLanguageNameVisible(languageName, false);
 });
 
-// TODO: Remove skip when the add fallback language function works
-test.skip('can remove fallback language', async ({umbracoApi, umbracoUi}) => {
+test('can remove fallback language', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   await umbracoApi.language.create(languageName, false, false, isoCode);
   expect(await umbracoApi.language.doesExist(isoCode)).toBeTruthy();
-  await umbracoUi.language.goToSettingsTreeItem('Language');
+  await umbracoUi.language.goToLanguages();
 
   // Act
   await umbracoUi.language.clickLanguageByName(languageName);
   await umbracoUi.language.removeFallbackLanguageByName(defaultLanguageName);
   await umbracoUi.language.clickSaveButton();
 
   // Act
+  await umbracoUi.language.isSuccessNotificationVisible();
   const languageData = await umbracoApi.language.get(isoCode);
   expect(languageData.fallbackIsoCode).toBeFalsy();
 });
 
-// TODO: Remove skip when the add fallback language function works
-test.skip('can add fallback language', async ({umbracoApi, umbracoUi}) => {
+test('can add fallback language', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   await umbracoApi.language.create(languageName, false, false, isoCode, null);
   expect(await umbracoApi.language.doesExist(isoCode)).toBeTruthy();
-  await umbracoUi.language.goToSettingsTreeItem('Language');
+  await umbracoUi.language.goToLanguages();
 
   // Act
   await umbracoUi.language.clickLanguageByName(languageName);
-  await umbracoUi.language.clickAddFallbackLanguageButton();
+  await umbracoUi.language.clickChooseButton();
   await umbracoUi.language.selectFallbackLanguageByName(defaultLanguageName);
   await umbracoUi.language.clickSaveButton();
 
   // Act
+  await umbracoUi.language.isSuccessNotificationVisible();
   const languageData = await umbracoApi.language.get(isoCode);
   expect(languageData.fallbackIsoCode).toBe(defaultLanguageIsoCode);
 });
+
+test('cannot add a language with duplicate ISO code', async ({umbracoApi, umbracoUi}) => {
+  // Arrange
+  await umbracoApi.language.create(languageName, false, false, isoCode);
+  expect(await umbracoApi.language.doesExist(isoCode)).toBeTruthy();
+  await umbracoUi.language.goToLanguages();
+
+  // Act
+  await umbracoUi.language.clickCreateLink();
+  await umbracoUi.language.chooseLanguageByName(languageName);
+  await umbracoUi.language.clickSaveButton();
+
+  // Assert
+  await umbracoUi.language.isErrorNotificationVisible();
+});

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeDesignTab.spec.ts

@@ -98,7 +98,7 @@ test('can add a description to property in a media type', {tag: '@smoke'}, async
   await umbracoUi.mediaType.goToMediaType(mediaTypeName);
   await umbracoUi.mediaType.clickEditorSettingsButton();
   await umbracoUi.mediaType.enterPropertyEditorDescription(descriptionText);
-  await umbracoUi.mediaType.clickUpdateButton();
+  await umbracoUi.mediaType.clickSubmitButton();
   await umbracoUi.mediaType.clickSaveButton();
 
   // Assert
@@ -118,7 +118,7 @@ test('can set a property as mandatory in a media type', {tag: '@smoke'}, async (
   await umbracoUi.mediaType.goToMediaType(mediaTypeName);
   await umbracoUi.mediaType.clickEditorSettingsButton();
   await umbracoUi.mediaType.clickMandatorySlider();
-  await umbracoUi.mediaType.clickUpdateButton();
+  await umbracoUi.mediaType.clickSubmitButton();
   await umbracoUi.mediaType.clickSaveButton();
 
   // Assert
@@ -140,7 +140,7 @@ test('can set up validation for a property in a media type', async ({umbracoApi,
   await umbracoUi.mediaType.selectValidationOption('');
   await umbracoUi.mediaType.enterRegEx(regex);
   await umbracoUi.mediaType.enterRegExMessage(regexMessage);
-  await umbracoUi.mediaType.clickUpdateButton();
+  await umbracoUi.mediaType.clickSubmitButton();
   await umbracoUi.mediaType.clickSaveButton();
 
   // Assert
@@ -159,7 +159,7 @@ test('can set appearance as label on top for property in a media type', async ({
   await umbracoUi.mediaType.goToMediaType(mediaTypeName);
   await umbracoUi.mediaType.clickEditorSettingsButton();
   await umbracoUi.mediaType.clickLabelAboveButton();
-  await umbracoUi.mediaType.clickUpdateButton();
+  await umbracoUi.mediaType.clickSubmitButton();
   await umbracoUi.mediaType.clickSaveButton();
 
   // Assert

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/PartialView/PartialView.spec.ts

@@ -1,4 +1,4 @@
 import {ConstantHelper, test} from '@umbraco/playwright-testhelpers';
 import {expect} from "@playwright/test";
 
 const partialViewName = 'TestPartialView';
@@ -30,7 +30,7 @@
   expect(await umbracoApi.partialView.doesNameExist(partialViewFileName)).toBeTruthy();
   // Verify the new partial view is displayed under the Partial Views section
   await umbracoUi.partialView.isPartialViewRootTreeItemVisibile(partialViewFileName);
-})
+});
 
 test('can create a partial view from snippet', async ({umbracoApi, umbracoUi}) => {
   // Arrange
@@ -279,3 +279,16 @@
   // Clean
   await umbracoApi.documentType.ensureNameNotExists(documentTypeName);
 });
+
+test('cannot create a partial view with an empty name', async ({umbracoApi, umbracoUi}) => {
+  // Act
+  await umbracoUi.partialView.clickActionsMenuAtRoot();
+  await umbracoUi.partialView.clickCreateButton();
+  await umbracoUi.partialView.clickNewEmptyPartialViewButton();
+  await umbracoUi.partialView.clickSaveButton();
+
+  // Assert
+  // TODO: Uncomment this when the front-end is ready. Currently there is no error displays.
+  //await umbracoUi.partialView.isErrorNotificationVisible();
+  expect(await umbracoApi.partialView.doesNameExist(partialViewFileName)).toBeFalsy();
+});