New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow save of invalid domains #16880

Merged

Zeegaan merged 1 commit into release/14.2 from v14/hotfix/do-not-allow-invalid-domains

Aug 7, 2024

Merged

Do not allow save of invalid domains #16880

Do not allow save of invalid domains

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (release/14.2) failed Aug 7, 2024 in 40s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.10 (9.22 -> 9.12)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

Complex Method DomainService.cs: UpdateDomainsAsync

Annotations

Check warning on line 209 in src/Umbraco.Core/Services/DomainService.cs

codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/14.2)

❌ New issue: Complex Method

UpdateDomainsAsync has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in tests/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/UrlAndDomains/DomainAndUrlsTests.cs

codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/14.2)

ℹ Getting worse: Code Duplication

introduced similar code in: Cannot_Assign_Duplicate_Domains,Cannot_Assign_Invalid_Domains. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

View more details on CodeScene Delta Analysis