Stripped username before login

[EmanuelGustafzon]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes here:

#16878

Description

I simply stripped the username before logging in a user if user accidently add a extra space.

I tried to signin with spaces before and after and it works fine.

[github-actions]

Hi there @EmanuelGustafzon, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[EmanuelGustafzon]

I accidentally a launchsetting.json and then I deleted the file but that caused the azure pipline checks to fail.

[bjarnef]

I would move this to client side in Angular handled previously.

username  = username.trim();

Trim user name before the following line.

https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Web.UI.Login/src/components/pages/login.page.element.ts#L76

As developers can implement other external login providers.

[EmanuelGustafzon]

That's a a good point @bjarnef thanks for the feedback

[emmagarland]

Hi @EmanuelGustafzon,

Thanks for your PR to fix #16878, to strip usernames before login. I can see you've implemented it as per @elit0451 suggestion in the issue. It worked for me locally so it has now been successfully merged! 🙌

Also, it looks like this is your first PR to this repository! Nice work! #H5YR 🎉 If you have an account on our.umbraco.com please feel free to drop a comment below with your account name. @nul800sebastiaan or one of the team will add you a lovely new C-Trib badge to your profile. 🏅

@bjarnef that is an interesting point re the front-end and other login provider implementations - perhaps this should be raised as a new issue (regarding this being in the front-end) for it to be implemented in the client-side too?

Best wishes

Emma

[EmanuelGustafzon]

Thank you @emmagarland for merging and yes this is my first contribution so it's exciting.

I just created an account so would appreciate a badge and my username is Emanuel Gustafzon.

https://our.umbraco.com/members/EmanuelGustafzon/

[nul800sebastiaan]

Congrats on your contrib badge @EmanuelGustafzon and thanks again for the PR! 🏅

[EmanuelGustafzon]

Thank you @nul800sebastiaan 🎉