Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Visual Studio's generated launchSettings file. #16951

Conversation

JasonElkin
Copy link
Contributor

The Umbraco.Tests.AcceptanceTest.UmbracoProject project is not a real web application and can't be run, but when Visual Studio sees the SDK it adds a launchSettings file.

This PR just ignores the file to prevent contributors that are using Visual Studio from accidentally adding it in their PRs.

Copy link

github-actions bot commented Aug 22, 2024

Hi there @JasonElkin, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @JasonElkin thanks for your PR 😄 someone on the core collaborators team will review this soon 😜

@Matthew-Wise Matthew-Wise self-assigned this Aug 25, 2024
@Matthew-Wise Matthew-Wise merged commit 862e45e into umbraco:contrib Aug 25, 2024
5 of 7 checks passed
@Matthew-Wise
Copy link
Contributor

Thanks Jason for your PR its a file I keep having to dodge as well 👍

@Matthew-Wise Matthew-Wise added release/no-notes This is too small to add to the release notes or fixed after a beta/RC release/14.3.0 community/pr labels Aug 25, 2024
@emmagarland
Copy link
Contributor

Same! Nice one

@JasonElkin JasonElkin deleted the chore/ignore-generated-launchSettings-file branch August 28, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr release/no-notes This is too small to add to the release notes or fixed after a beta/RC release/14.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants