-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warnings from Umbraco.Web.UI #16958
Remove warnings from Umbraco.Web.UI #16958
Conversation
# Conflicts: # src/Umbraco.Web.UI/Startup.cs
… hotfix/15015-removewarnings-umbracowebui
Hi there @emmagarland, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey @emmagarland, thanks for the PR, I have taken a look at this and all looks good, therefore I have gone ahead and merged this one! 💯 |
Amazing! Thanks @georgebid 👍 |
Fixed warning SA1119 for Umbraco.Web.UI project
Fixed StyleCop warning SA1119 (unnecessary parenthesis) for
Umbraco.Web.UI
project, and no warnings show up in that project now.Prerequisites
If there's an existing issue for this PR then this fixes: part of my issue #15015
Description
Continuation of removal of warnings per project - replicating change made in #15110, the original
Startup.cs
file, which wasn't pulled across intoProgram.cs
when removed