Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: Fix templates not having set master template on package install #16978

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Aug 29, 2024

Notes

  • When installing packages like Umbraco.TheStarterKit, the templates would never have their correct master template set.
  • This would also cause issues with Deploy, as when you'd send content to cloud, it would cause errors.
  • This PR remedies this issue, by ordering the templates correctly, by using the new TemplateContentParserService when installing package data (this was broken using Xelements)

How to test

  • Install the Umbraco.TheStarterKit NuGet package
  • Run Umbraco
  • Assert that 9 templates have the "master" template set.

@Zeegaan Zeegaan marked this pull request as ready for review August 29, 2024 09:46
Copy link
Contributor

@Migaroez Migaroez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Works as expected
✅ Updated code to avoid multiple GetAwaiter().GetResult() statements in the same method.

@bergmania bergmania merged commit f72c39e into v14/dev Sep 17, 2024
15 of 19 checks passed
@bergmania bergmania deleted the v14/bugfix/fix-package-data-template-installation branch September 17, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants