Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorAlias to content value outputs #17032

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Sep 10, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The pending clipboard feature (and in part also block level variance) would benefit greatly from knowing up-front what kind of value editor is backing a content property value. To achieve this, we need an "editorAlias" property to each value in the content endpoint outputs (documents, media, member).

There will be a follow-up to this at block level for block level variance.

Testing this PR

  1. It should be possible to edit and save existing documents, media and members. Make sure you test this on items with properties 😄
  2. Also verify that collection views still work as per usual (try a media folder).
  3. Lastly, the output from a content endpoint (i.e. GET document) should contain editorAlias for each property value:
    image

Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good 👍

@nikolajlauridsen nikolajlauridsen merged commit 6dae502 into v15/dev Sep 16, 2024
16 of 17 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v15/feature/content-value-editor-alias branch September 16, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants