Add AsyncMigrationBase, update base classes and call async methods
#17057
Conversation
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| [Obsolete] | ||
| private void HandlePostMigrations(ExecutedMigrationPlan result) | ||
| private async Task HandlePostMigrationsAsync(ExecutedMigrationPlan result) |
There was a problem hiding this comment.
The post migrations have been obsoleted for a while (even stated for removal in v13, which didn't happen), but removing them should be done in a separate PR.
| namespace Umbraco.Cms.Infrastructure.Migrations; | ||
|
|
||
| public class NoopMigration : MigrationBase | ||
| public class NoopMigration : AsyncMigrationBase |
There was a problem hiding this comment.
This could be reverted back to MigrationBase to avoid an extra breaking change (so the base class doesn't change)... We have similar base class changes in UnscopedMigrationBase and PackageMigrationBase, which also don't inherit from MigrationBase anymore, but can't be fixed (because you can't simultaneously inherit from two base classes).
|
To me, I seems like there is a lot of breaking changes, that is not strictly necessary. Couldn't we let all the existing logic work as obsoleted, but introduce async migrations next to the existing. Thereby you would not have to change any base classes, you could just make a new version of the classes, E.g. NoopMigrationAsync |
Prerequisites
Description
Similar to #16536, this PR makes it possible to (correctly) call async methods in migrations. I've done the following:
AsyncMigrationBasewith newRunAsync()andMigrateAsync()methods, made this the base class ofMigrationBaseand moved most methods into this new class;UnscopedAsyncMigrationBaseand made this the base class ofUnscopedMigrationBase, addedAsyncPackageMigrationBaseand made this the base class ofPackageMigrationBase;IMigrationPlanExecutorto only have anExecutePlanAsync()method;Testing should be done by ensuring a clean install creates and updates the database correctly and checking whether the code and tests are all good 😄