Enable validation of specific cultures only for document updates #17087
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev)
succeeded
Sep 25, 2024 in 35s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.08 (8.60 -> 8.68)
- Improving Code Health: 2 findings(s) ✅
Details
✅ Improving Code Health:
- Primitive Obsession ContentEditingService.cs
- Primitive Obsession ContentEditingServiceBase.cs
Annotations
Check notice on line 1 in src/Umbraco.Core/Services/ContentEditingService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 63.64% to 62.32%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 1 in src/Umbraco.Core/Services/ContentEditingServiceBase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 39.66% to 38.33%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
ℹ Getting worse: Code Duplication
introduced similar code in: Can_Validate_For_All_Languages,Can_Validate_For_Specific_Language. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Loading