Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute V15 User data migrations as pre-migrations #17140

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Sep 26, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Similarly to #17130, we also need execute the V15 migrations affecting User data as pre-migrations.

As it happens, one of the V14 migrations (MigrateTours) must run before the V15 ones can run, so that one has been moved to pre-migrations as well. To achieve a smooth transition to V15 from both V14 and V13:

  1. MigrateTours has been replaced with a no-op migration in the regular upgrade plan.
  2. MigrateTours has slightly altered to exit fast, in case it has already run (which will be the case in a V14 to V15 upgrade).

Testing this PR

Verify that both attended and unattended upgrades work from V14 to V15 and from V13 to V15.

Run these tests for both SQLite and SQL Server.

…migrations

# Conflicts:
#	src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs
#	src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPremigrationPlan.cs
@elit0451 elit0451 merged commit 349b102 into v15/dev Sep 27, 2024
13 of 17 checks passed
@elit0451 elit0451 deleted the v15/fix/user-migrations-as-premigrations branch September 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants