Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Media in new cache was created as published #17169

Merged
merged 1 commit into from
Oct 2, 2024

Fixes issues with database rebuild and the fact media was created as …

e9cbea5
Select commit
Loading
Failed to load commit list.
Merged

Bugfix: Media in new cache was created as published #17169

Fixes issues with database rebuild and the fact media was created as …
e9cbea5
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (release/15.0) succeeded Oct 1, 2024 in 29s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.04 (5.93 -> 5.98)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Complex Method DatabaseCacheRepository.cs: Rebuild

Annotations

Check notice on line 123 in src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)

✅ Getting better: Complex Method 

Rebuild decreases in cyclomatic complexity from 12 to 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis