Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Umbraco.Tests.Common warnings. #17172

Open
wants to merge 7 commits into
base: contrib
Choose a base branch
from

Conversation

jbreuer
Copy link
Contributor

@jbreuer jbreuer commented Oct 2, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Issue: #15015

Description

This PR fixes the following task:

Warnings in Umbraco.Tests.Common.

This PR can be tested by building the Umbraco source code and checking that this warnings for Umbraco.Tests.Common are gone.

Copy link

github-actions bot commented Oct 2, 2024

Hi there @jbreuer, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@jbreuer
Copy link
Contributor Author

jbreuer commented Oct 3, 2024

When I created this PR there weren't any merge conflicts. Not sure what happend.

@mikecp
Copy link
Contributor

mikecp commented Oct 8, 2024

Hi @jbreuer ,

Thanks for providing the fix for this issue 👍
Someone from the core collaborators team will have a look at it soon.

Regarding the merge conflicts, I think your PR was more or less created at the same time as the release of V15 RC, which was merged into the contrib branch after your PR, hence possibiy creating the conflict... Or something like that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants