-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Umbraco.Tests.Common warnings. #17172
base: contrib
Are you sure you want to change the base?
Fix Umbraco.Tests.Common warnings. #17172
Conversation
Hi there @jbreuer, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
When I created this PR there weren't any merge conflicts. Not sure what happend. |
Hi @jbreuer , Thanks for providing the fix for this issue 👍 Regarding the merge conflicts, I think your PR was more or less created at the same time as the release of V15 RC, which was merged into the contrib branch after your PR, hence possibiy creating the conflict... Or something like that 😅 |
Prerequisites
Issue: #15015
Description
This PR fixes the following task:
This PR can be tested by building the Umbraco source code and checking that this warnings for Umbraco.Tests.Common are gone.