Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swiss languages as backoffice languages #17177

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

marwaldv
Copy link
Contributor

@marwaldv marwaldv commented Oct 2, 2024

Add missing backoffice languages as properties etc. are translated via translation section (e.g. with "#Backoffice Settings"). At the moment the swiss languages always need to be added via the umbraco/Config folder.

Add missing backoffice languages as properties etc. are translated via translation section (e.g. with "#Backoffice Settings"). At the moment the swiss languages always need to be added via the umbraco/Config folder.
Copy link

github-actions bot commented Oct 2, 2024

Hi there @marwaldv, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Oct 2, 2024

Thanks a lot @marwaldv for those new translations files 👍
Someone from the Core Collaborators team will have a look at your PR soon!

@iOvergaard
Copy link
Contributor

@marwaldv Would you mind adding these to the new Backoffice as well (V14, V15)?

The format has moved to JSON, but if you spin up a V13 Backoffice, you can look in the network tab and find a request to "localizedText" and essentially copy the body of that over. The new Backoffice repository is found here and the localization files are found under src/assets/lang.

@iOvergaard iOvergaard added the status/deferred-new-backoffice This change is something that needs to (also) be built into the new backoffice (>=14.0.0). label Oct 16, 2024
@nul800sebastiaan
Copy link
Member

Hi there @marwaldv! Thanks again!

Just a hint: as you may know, this PR qualifies for Umbraco's Hacktoberfest participation for which you can earn rewards.
If you were to make 1 more contribution in the next few days, would be great to see your contributions qualify! You can do it.. 😉

@marwaldv
Copy link
Contributor Author

marwaldv commented Oct 31, 2024

@marwaldv Would you mind adding these to the new Backoffice as well (V14, V15)?

The format has moved to JSON, but if you spin up a V13 Backoffice, you can look in the network tab and find a request to "localizedText" and essentially copy the body of that over. The new Backoffice repository is found here and the localization files are found under src/assets/lang.

@iOvergaard In which repositories would I need to create a pull request for V14 and V15?

@iOvergaard
Copy link
Contributor

@marwaldv The Umbraco.CMS.Backoffice repository is the place to create those. You should fork it and create a pull request to the main branch with the changes. Thanks so much for doing this!

@marwaldv
Copy link
Contributor Author

marwaldv commented Nov 1, 2024

@marwaldv The Umbraco.CMS.Backoffice repository is the place to create those. You should fork it and create a pull request to the main branch with the changes. Thanks so much for doing this!

@iOvergaard here you go: umbraco/Umbraco.CMS.Backoffice#2503

@iOvergaard iOvergaard merged commit 79d1170 into umbraco:v13/contrib Nov 9, 2024
16 checks passed
@umbrabot
Copy link

umbrabot commented Dec 4, 2024

Hi there @marwaldv!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

image

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25nd, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr hacktoberfest/contrib-2024 hacktoberfest-accepted release/13.6.0 status/deferred-new-backoffice This change is something that needs to (also) be built into the new backoffice (>=14.0.0).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants