Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #17225. Extended RTE valid element configuration #17227

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

wwrobel
Copy link

@wwrobel wwrobel commented Oct 9, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

This PR is connected to the issue 17225.

When you select the Code "Container" from the dropdown in the RTE (see the screenshot below), the styling is initially applied but removed again when saving.
image

How to reproduce

  1. Go to RTE property and type some text.
  2. Select the text and set the styling to Containers/Code as shown on the above screenshot.
  3. (Optional) Take a look on RTE html generated, there will be only the text surrounded by <p></p> instead of <p><code></code></p>.
  4. Save changes.
  5. Code text in RTE will be surrounded only by <p></p>, so code style won't be applied.

Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will transfer this to V14 and V15 as well.

@iOvergaard iOvergaard merged commit 3730109 into umbraco:v13/contrib Oct 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants