Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V15: Reimplement cache startup handler #17279

Merged
merged 4 commits into from
Oct 15, 2024

formatting

80fe101
Select commit
Loading
Failed to load commit list.
Merged

V15: Reimplement cache startup handler #17279

formatting
80fe101
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (release/15.0) succeeded Oct 15, 2024 in 32s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.12 (10.00 -> 9.88)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Constructor Over-Injection DatabaseCacheRebuilder.cs: DatabaseCacheRebuilder

Annotations

Check warning on line 34 in src/Umbraco.PublishedCache.HybridCache/DatabaseCacheRebuilder.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)

❌ New issue: Constructor Over-Injection 

DatabaseCacheRebuilder has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
View more details on CodeScene Delta Analysis