Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for block level variation #17355

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 24, 2024

Description

Adds proper validation support for block level variance.

More description and test steps will come later.

Breaking changes

  • IDataValueEditor.Validate()
  • BlockEditorValidatorBase.GetBlockEditorDataValidation()

Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some pedantic things, feel free to ignore some 👍

kjac and others added 3 commits October 29, 2024 14:14
Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
…rBase.cs

Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
@kjac kjac marked this pull request as ready for review October 29, 2024 13:18
Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kjac kjac merged commit 5fe91f8 into release/15.0 Oct 31, 2024
14 of 15 checks passed
@kjac kjac deleted the v15/fix/block-level-variation-validation branch October 31, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants