Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize important services before unattended installs #17366

Conversation

bergmania
Copy link
Member

Description

Fixes a couple of ordering stuff, so unattended install works as expected.

  • Fixed some potential locking issues in the AmbiantScopeStacks.
  • Removed old Assembly name from the typefinder - We should consider making that list up to date on another PR, but this change just avoids an exception in the log.
  • Refactored some hosted services to notifications because they need to execute before unattended install, and the CoreRuntime is executed before hosted services since the Minimal Hosting Model was introduced.
  • Move a couple of v14.0 migrations to premigrations to allow stuff to work when upgrading fra v13
  • Fixed parallel issue in ConvertBlockEditorPropertiesBase
    • We need to call SuppressFlow when the task is created, but not with the await inside
      • If await is inside, the thread continuing after await is not the same (even with ConfigureAwait(true))
      • It is required on the task, to ensure the AsyncLocals (and thereby the AmbianScopeStack) is null when the task begins
  • Fixed a series of smaller (nullablilty) issues, when running with compile-variable DEBUG_SCOPES
  • Moved scope creation in DocumentCacheService and MediaCacheService inside the factory method, so we do not create a scope, if we do not touch the database
  • Fixed tests according to the above changes.

Tests

  • Migrate different v13 databases :)

Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💪

@bergmania bergmania merged commit 935c3b8 into release/15.0 Oct 28, 2024
14 of 15 checks passed
@bergmania bergmania deleted the v15/hotfix/initialize-important-services-before-unattended--installs branch October 28, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants