-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Redirect when server file is renamed #17663
Merged
nielslyngsoe
merged 23 commits into
v15/dev
from
v15/bugfix/rename-server-file-redirect
Nov 29, 2024
Merged
Bugfix: Redirect when server file is renamed #17663
nielslyngsoe
merged 23 commits into
v15/dev
from
v15/bugfix/rename-server-file-redirect
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16488
This (PR) addresses the issue where a renamed file system workspace enters an "undefined" state. The problem arises because the file name serves as the unique identifier for the workspace. When the file name is changed, the unique identifier is also changed, causing the workspace to become "undefined." To resolve this, we need to notify the workspace about both the unique before the change and after the change, allowing us to target the correct workspace and redirect it to the new path.
The PR introduces the
UmbServerFileRenameWorkspaceRedirectController
, which listens for aServerFileRenamed
action event. This event includes both the previous and new uniques. If the currently open workspace matches the event, the controller will redirect it to the new location.What to test:
Kapture.2024-11-29.at.08.50.36.mp4