-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust block list configuration #8661
Adjust block list configuration #8661
Conversation
@nielslyngsoe do you know why we have both html, js and less inside https://github.com/umbraco/Umbraco-CMS/tree/v8/contrib/src/Umbraco.Web.UI.Client/src/views/propertyeditors/blocklist and not separating as with other part of the existing code? Directives/components Less Component views Furthermore angular components are custom HTML elements, so the can't be void elements (self-closing):
Submitted a PR for the last part here: #8662 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, and thanks for testing this out 🤩
@bjarnef So the reasoning for having both HTML, JS, and LESS inside is to gather the files of one concern to provide a better overview. We have a few other things that does it this way. I'm fully aware that we break the original file structure, but the intention is for the better, otherwise, you can only find related files through references. |
@nielslyngsoe maybe regarding the property editor and prevalue editor, but for the component itself it seems a bit inconsistent where more or less all other components have the HTML, JS, LESS part structured in separate folders. In fact recently I only found two components which had a different structure from all others. |
Replaced with PR #8686 |
Prerequisites
Description
I have added a few changes to the configuration of the block list
esc
shortcutumb-node-preview
.https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/less/components/umb-node-preview.less
Furthermore in this overlay these "Add" buttons has border radius which the default
umb-node-preview
doesn't have. Make we should start using a new class name which can be used for this picker button and re-used throughout the UI since it is re-used in many pickers, sometimes with copied styling to another class, so when the styling on the originalumb-node-preview
class change a bit, the others buttons starts being inconsistent.I also noticed when using tabs key to to focus "delete" action it trigger both "delete" overlay and "edit" overlay, where it seems to bubble to parent
ng-click
although the "delete" button event should stop event bubbling (it should on mouse click, but not via enter key).