Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust block list configuration #8661

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Aug 19, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Description

I have added a few changes to the configuration of the block list

Furthermore in this overlay these "Add" buttons has border radius which the default umb-node-preview doesn't have. Make we should start using a new class name which can be used for this picker button and re-used throughout the UI since it is re-used in many pickers, sometimes with copied styling to another class, so when the styling on the original umb-node-preview class change a bit, the others buttons starts being inconsistent.

I also noticed when using tabs key to to focus "delete" action it trigger both "delete" overlay and "edit" overlay, where it seems to bubble to parent ng-click although the "delete" button event should stop event bubbling (it should on mouse click, but not via enter key).

2020-08-19_17-46-04

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 19, 2020

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, and thanks for testing this out 🤩

@nielslyngsoe
Copy link
Member

@bjarnef So the reasoning for having both HTML, JS, and LESS inside is to gather the files of one concern to provide a better overview. We have a few other things that does it this way. I'm fully aware that we break the original file structure, but the intention is for the better, otherwise, you can only find related files through references.

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 20, 2020

@nielslyngsoe maybe regarding the property editor and prevalue editor, but for the component itself it seems a bit inconsistent where more or less all other components have the HTML, JS, LESS part structured in separate folders.

In fact recently I only found two components which had a different structure from all others.

#8566
#8565

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 20, 2020

Replaced with PR #8686

@bjarnef bjarnef closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants