Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing icon shown for package actions group #9065

Closed

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Oct 4, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Description

In #5606 <umb-icon> component was adding and the icon in the icon in header of the expansion panels was replaced with <umb-icon>.

However for package actions it wasn't rendered correct, which this PR fixes.

@bjarnef
Copy link
Contributor Author

bjarnef commented Dec 2, 2020

@nathanwoulfe maybe you would like to test this one? I guess we don't need the second part regarding setting the icon classes anyway, but in that case we might also want to clear up the other panel icons.

Panels was changed a bit before initial release of v8 as I recall, but still used here and useful in some context, e.g. in packages.

I wonder if these should be components instead like <umb-box>.

<umb-panel>
   <umb-panel-header>
      ...
   </umb-panel-header>
   <umb-panel-content>
      ...
   </umb-panel-content>
</umb-panel>

or it could be named <umb-accordion>.

//cc @nielslyngsoe

@nathanwoulfe
Copy link
Contributor

@bjarnef looks like @BatJan beat you to it - he fixed this issue as part of #9054

@bjarnef bjarnef deleted the v8/bug/expansion-panel-header-icon branch December 6, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants