Skip to content

Refined the Content webhooks mostly to remove Messages & State proper…

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev) succeeded Nov 22, 2023 in 1m 37s

CodeScene PR Check

βœ… Code Health Quality Gates: OK

  • Declining Code Health: 7 findings(s) 🚩
  • Improving Code Health: 0 findings(s) βœ…
  • Affected Hotspots: 1 files(s) πŸ”₯

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Constructor Over-Injection ContentEmptiedRecycleBinWebhookEvent.cs: ContentEmptiedRecycleBinWebhookEvent
  • Constructor Over-Injection ContentPublishedWebhookEvent.cs: ContentPublishedWebhookEvent
  • Constructor Over-Injection ContentRolledBack.cs: ContentRolledBackWebhookEvent
  • Constructor Over-Injection ContentSavedWebhookEvent.cs: ContentSavedWebhookEvent
  • Complex Method ContentSortedWebhookEvent.cs: ConvertNotificationToRequestPayload
  • Constructor Over-Injection ContentSortedWebhookEvent.cs: ContentSortedWebhookEvent
  • Constructor Over-Injection MediaSavedWebhookEvent.cs: MediaSavedWebhookEvent

Annotations

Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Media/MediaSavedWebhookEvent.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Constructor Over-Injection

MediaSavedWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.

Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Content/ContentPublishedWebhookEvent.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Constructor Over-Injection

ContentPublishedWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.

Check warning on line 33 in src/Umbraco.Core/Webhooks/Events/Content/ContentEmptiedRecycleBinWebhookEvent.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Constructor Over-Injection

ContentEmptiedRecycleBinWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.

Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Content/ContentRolledBack.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Constructor Over-Injection

ContentRolledBackWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.

Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Content/ContentSavedWebhookEvent.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Constructor Over-Injection

ContentSavedWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.

Check warning on line 52 in src/Umbraco.Core/Webhooks/Events/Content/ContentSortedWebhookEvent.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Complex Method

ConvertNotificationToRequestPayload has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Content/ContentSortedWebhookEvent.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Constructor Over-Injection

ContentSortedWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.

Check notice on line 1 in src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

β„Ή Getting worse: Lines of Code in a Single File

The lines of code increases from 2123 to 2124, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1 in src/Umbraco.PublishedCache.NuCache/ContentStore.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

β„Ή Getting worse: Lines of Code in a Single File

The lines of code increases from 1146 to 1150, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.