Ensure there is always at least 1 valid candidate
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)
failed
May 22, 2024 in 39s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional EagerMatcherPolicy.cs: ApplyAsync
Annotations
Check notice on line 135 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
ℹ Getting worse: Complex Method
ApplyAsync increases in cyclomatic complexity from 15 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 135 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ Getting worse: Complex Conditional
ApplyAsync increases from 1 complex conditionals with 2 branches to 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check notice on line 1 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.57 to 5.00, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading