Skip to content

prevent block grid from setting and initial empty block object value

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (release/15.1) succeeded Dec 11, 2024 in 31s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.18 (9.71 -> 9.52)

  • Declining Code Health: 2 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method property-editor-ui-block-list.element.ts: UmbPropertyEditorUIBlockListElement.constructor 🔥
  • Complex Method property-editor-ui-block-grid.element.ts: UmbPropertyEditorUIBlockGridElement.constructor

Annotations

Check warning on line 212 in src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.1)

❌ Getting worse: Complex Method 

UmbPropertyEditorUIBlockListElement.constructor increases in cyclomatic complexity from 9 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 140 in src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.1)

❌ New issue: Complex Method 

UmbPropertyEditorUIBlockGridElement.constructor has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis