Merge pull request #2073 from umbraco/dependabot/npm_and_yarn/eslint-…

…9.6.0

Bump eslint from 8.57.0 to 9.6.0

.github/workflows/build_test.yml

@@ -36,7 +36,8 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
-          cache: 'npm'
+          cache: npm
+          cache-dependency-path: package-lock.json
       - run: npm ci --no-audit --no-fund --prefer-offline
       - run: npm run lint:errors
       - run: npm run build

.prettierignore

@@ -1,2 +1,4 @@
 # Ignore auto-generated backend-api files
 src/external/backend-api/src
+src/packages/core/icon-registry/icons.ts
+src/packages/core/icon-registry/icons

devops/eslint/rules/exported-string-constant-naming.cjs

@@ -1,16 +1,31 @@
+/** @type {import('eslint').Rule.RuleModule}*/
 module.exports = {
 	meta: {
 		type: 'problem',
 		docs: {
 			description:
 				'Ensure all exported string constants should be in uppercase with words separated by underscores and prefixed with UMB_',
 		},
+		schema: [
+			{
+				type: 'object',
+				properties: {
+					excludedFileNames: {
+						type: 'array',
+						items: {
+							type: 'string',
+						},
+					},
+				},
+				additionalProperties: false,
+			},
+		],
 	},
 	create: function (context) {
 		const excludedFileNames = context.options[0]?.excludedFileNames || [];
 		return {
 			ExportNamedDeclaration(node) {
-				const fileName = context.getFilename();
+				const fileName = context.filename;
 
 				if (excludedFileNames.some((excludedFileName) => fileName.includes(excludedFileName))) {
 					// Skip the rule check for files in the excluded list

eslint.config.js

@@ -0,0 +1,96 @@
+import js from "@eslint/js";
+import globals from "globals";
+import importPlugin from "eslint-plugin-import";
+import localRules from "eslint-plugin-local-rules";
+import wcPlugin from "eslint-plugin-wc";
+import litPlugin from "eslint-plugin-lit";
+import litA11yPlugin from "eslint-plugin-lit-a11y";
+import storybookPlugin from "eslint-plugin-storybook";
+import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
+import tseslint from 'typescript-eslint';
+
+export default [
+	// Recommended config applied to all files
+	js.configs.recommended,
+	...tseslint.configs.recommended,
+	eslintPluginPrettierRecommended,
+
+	// Global ignores
+	{
+		ignores: [
+			"**/rollup.config.js",
+			"**/vite.config.ts",
+			"src/external",
+			"src/packages/core/icon-registry/icons",
+			"src/packages/core/icon-registry/icons.ts"
+		],
+	},
+
+	// Global config
+	{
+		languageOptions: {
+			parserOptions: {
+				project: true,
+				tsconfigRootDir: import.meta.dirname,
+			},
+			globals: {
+				...globals.browser,
+			}
+		},
+		plugins: {
+			import: importPlugin,
+			"local-rules": localRules,
+			"wc": wcPlugin,
+			"lit": litPlugin,
+			"lit-a11y": litA11yPlugin,
+			"storybook": storybookPlugin
+		},
+		rules: {
+			semi: ["warn", "always"],
+			"no-unused-vars": "warn",
+			"no-var": "error",
+			"import/no-unresolved": "off",
+			"import/order": ["warn", { "groups": ["builtin", "parent", "sibling", "index", "external"] }],
+			"import/no-self-import": "error",
+			"import/no-cycle": ["error", { "maxDepth": 6, "allowUnsafeDynamicCyclicDependency": true }],
+			"local-rules/bad-type-import": "error",
+			"local-rules/enforce-element-suffix-on-element-class-name": "error",
+			"local-rules/enforce-umb-prefix-on-element-name": "error",
+			"local-rules/ensure-relative-import-use-js-extension": "error",
+			"local-rules/no-direct-api-import": "warn",
+			"local-rules/prefer-import-aliases": "error",
+			"local-rules/prefer-static-styles-last": "warn",
+			"local-rules/umb-class-prefix": "error",
+			"local-rules/no-relative-import-to-import-map-module": "error",
+			"local-rules/enforce-umbraco-external-imports": [
+				"error",
+				{
+					"exceptions": ["@umbraco-cms", "@open-wc/testing", "@storybook", "msw", ".", "vite"]
+				}
+			],
+			"local-rules/exported-string-constant-naming": [
+				"error",
+				{
+					"excludedFileNames": ["umbraco-package", "input-tiny-mce.defaults"] // TODO: what to do about the tiny mce defaults?
+				}
+			],
+			"@typescript-eslint/no-non-null-assertion": "off",
+			"@typescript-eslint/no-explicit-any": "warn",
+			"@typescript-eslint/no-unused-vars": "warn",
+			"@typescript-eslint/consistent-type-exports": "error",
+			"@typescript-eslint/consistent-type-imports": "error",
+			"@typescript-eslint/no-import-type-side-effects": "warn"
+		}
+	},
+
+	// Pattern-specific overrides
+	{
+		files: ['**/*.js'],
+		...tseslint.configs.disableTypeChecked,
+		languageOptions: {
+			globals: {
+				...globals.node,
+			}
+		}
+	},
+];