Chore: Lee's code sweep (during Hacktoberfest '24) (#2450)

* Removed my outdated TODO comments

* Manifest Picker code tidy-up

* Attribute tidy-up

Things I'd picked up during development

* Corrects Storybook control type for `umb-localize` key

* Ran `npm run lint:fix`

examples/manifest-picker/manifest-picker-dashboard.ts

@@ -1,11 +1,13 @@
 import { css, html, customElement, state, when, nothing } from '@umbraco-cms/backoffice/external/lit';
 import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
-import { UmbInputManifestElement } from '@umbraco-cms/backoffice/components';
+import type { UmbInputManifestElement } from '@umbraco-cms/backoffice/components';
 import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
-import { UUISelectEvent } from '@umbraco-cms/backoffice/external/uui';
+import type { UUISelectEvent } from '@umbraco-cms/backoffice/external/uui';
 
+// eslint-disable-next-line local-rules/enforce-umb-prefix-on-element-name
 @customElement('example-manifest-picker-dashboard')
+// eslint-disable-next-line local-rules/enforce-element-suffix-on-element-class-name, local-rules/umb-class-prefix
 export class ExampleManifestPickerDashboard extends UmbLitElement {
 	#options: Array<Option> = [];
 

src/apps/preview/preview.context.ts

@@ -149,7 +149,6 @@ export class UmbPreviewContext extends UmbContextBase<UmbPreviewContext> {
 		window.open(url, '_blank');
 	}
 
-	// TODO: [LK] Figure out how to make `iframe.contentDocument` works, as it's not from SameOrigin.
 	reloadIFrame(iframe: HTMLIFrameElement) {
 		const document = iframe.contentDocument;
 		if (!document) return;

src/packages/core/collection/types.ts

@@ -26,10 +26,8 @@ export interface UmbCollectionConfiguration {
 export interface UmbCollectionColumnConfiguration {
 	alias: string;
 	header: string;
-	// TODO: [LK] Figure out why the server API needs an int (1|0) instead of a boolean.
 	isSystem: 1 | 0;
 	elementName?: string;
-	// TODO: [LK] Remove `nameTemplate`, to be replaced with `elementName`.
 	nameTemplate?: string;
 }
 

src/packages/core/localization/manifests.ts

@@ -260,5 +260,5 @@ export const manifests: Array<ManifestLocalization> = [
 			culture: 'zh-tw',
 		},
 		js: () => import('../../../assets/lang/zh-tw.js'),
-	}
+	},
 ];

src/packages/core/localization/stories/localize.element.stories.ts

@@ -12,7 +12,7 @@ const meta: Meta<UmbLocalizeElement> = {
 	argTypes: {
 		args: {
 			control: {
-				type: 'array',
+				type: 'text',
 			},
 		},
 	},

src/packages/core/menu/section-sidebar-menu/section-sidebar-menu.element.ts

@@ -1,10 +1,10 @@
+import type { ManifestMenu } from '../menu.extension.js';
 import type { ManifestSectionSidebarAppBaseMenu, ManifestSectionSidebarAppMenuKind } from './types.js';
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
 import { css, html, customElement, property } from '@umbraco-cms/backoffice/external/lit';
 import type { UmbExtensionManifestKind } from '@umbraco-cms/backoffice/extension-registry';
 import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
 import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
-import type { ManifestMenu } from '../menu.extension.js';
 
 // TODO: Move to separate file:
 const manifest: UmbExtensionManifestKind = {

src/packages/core/section/section-sidebar-context-menu/section-sidebar-context-menu.element.ts

@@ -154,7 +154,7 @@ export class UmbSectionSidebarContextMenuElement extends UmbLitElement {
 				display: flex;
 				align-items: center;
 			}
-			#action-modal umb-entity-action-list{
+			#action-modal umb-entity-action-list {
 				--uui-menu-item-flat-structure: 0;
 			}
 		`,

src/packages/documents/document-types/workspace/document-type-workspace-editor.element.ts

@@ -91,7 +91,7 @@ export class UmbDocumentTypeWorkspaceEditorElement extends UmbLitElement {
 							.value=${this._name}
 							.alias=${this._alias}
 							?auto-generate-alias=${this._isNew}
-							@change="${this.#onNameAndAliasChange}"
+							@change=${this.#onNameAndAliasChange}
 							required
 							${umbBindToValidation(this, '$.name', this._name)}
 							${umbFocus()}>

src/packages/documents/document-types/workspace/views/templates/document-type-workspace-view-templates.element.ts

@@ -91,20 +91,19 @@ export class UmbDocumentTypeWorkspaceViewTemplatesElement extends UmbLitElement
 
 	#renderTemplates() {
 		return html`
-			<uui-box headline="${this.localize.term('treeHeaders_templates')}">
+			<uui-box headline=${this.localize.term('treeHeaders_templates')}>
 				${when(
 					this.#workspaceContext?.createTemplateMode,
 					() => html`<p><em>The default template will be created once this document type has been saved.</em></p>`,
 				)}
-				<umb-property-layout
-					alias="Templates"
-					label="${this.localize.term('contentTypeEditor_allowedTemplatesHeading')}">
+				<umb-property-layout alias="Templates" label=${this.localize.term('contentTypeEditor_allowedTemplatesHeading')}>
 					<div slot="description">${this.localize.term('contentTypeEditor_allowedTemplatesDescription')}</div>
 					<div id="templates" slot="editor">
 						<umb-input-template
 							.defaultUnique=${this._defaultTemplateId ?? ''}
 							.selection=${this._allowedTemplateIds}
-							@change=${this.#templateInputChange}></umb-input-template>
+							@change=${this.#templateInputChange}>
+						</umb-input-template>
 					</div>
 				</umb-property-layout>
 			</uui-box>

src/packages/media/media-types/workspace/media-type-workspace-editor.element.ts

@@ -95,7 +95,7 @@ export class UmbMediaTypeWorkspaceEditorElement extends UmbLitElement {
 							value=${this._name}
 							alias=${this._alias}
 							?auto-generate-alias=${this._isNew}
-							@change="${this.#onNameAndAliasChange}"
+							@change=${this.#onNameAndAliasChange}
 							${umbFocus()}>
 						</umb-input-with-alias>
 

src/packages/media/media/components/input-image-cropper/image-cropper-focus-setter.element.ts

@@ -17,7 +17,6 @@ export class UmbImageCropperFocusSetterElement extends LitElement {
 	@property({ attribute: false })
 	focalPoint: UmbImageCropperFocalPoint = { left: 0.5, top: 0.5 };
 
-	// TODO: [LK] Temporary fix; to be reviewed.
 	@property({ type: Boolean })
 	hideFocalPoint = false;
 

src/packages/members/member-type/workspace/member-type-workspace-editor.element.ts

@@ -90,7 +90,7 @@ export class UmbMemberTypeWorkspaceEditorElement extends UmbLitElement {
 							value=${this._name}
 							alias=${this._alias}
 							?auto-generate-alias=${this._isNew}
-							@change="${this.#onNameAndAliasChange}"
+							@change=${this.#onNameAndAliasChange}
 							${umbFocus()}>
 						</umb-input-with-alias>
 

src/packages/property-editors/content-picker/config/source/input-content-picker-source.element.ts

@@ -97,7 +97,7 @@ export class UmbInputContentPickerSourceElement extends UUIFormControlMixin(UmbL
 
 	override render() {
 		return html`<umb-input-dropdown-list
-				@change="${this.#onContentTypeChange}"
+				@change=${this.#onContentTypeChange}
 				.options=${this._options}></umb-input-dropdown-list>
 			${this.#renderSourcePicker()}`;
 	}

src/packages/templating/templates/global-components/input-template/input-template.element.ts

@@ -173,16 +173,16 @@ export class UmbInputTemplateElement extends UUIFormControlMixin(UmbLitElement,
 			${this._pickedTemplates.map(
 				(template) => html`
 					<umb-template-card
-						.name=${template.name}
 						.id=${template.unique}
-						@open=${() => window.history.pushState({}, '', this.#templatePath + 'edit/' + template.unique)}
+						.name=${template.name}
 						@change=${this.#onCardChange}
-						?default="${template.unique === this.defaultUnique}">
+						@open=${() => window.history.pushState({}, '', this.#templatePath + 'edit/' + template.unique)}
+						?default=${template.unique === this.defaultUnique}>
 						<uui-button
 							slot="actions"
-							label="${this.localize.term('general_remove') + ' ' + template.name}"
-							@click="${() => this.#removeTemplate(template.unique ?? '')}"
-							compact>
+							compact
+							label=${this.localize.term('general_remove') + ' ' + template.name}
+							@click=${() => this.#removeTemplate(template.unique ?? '')}>
 							<uui-icon name="icon-trash"></uui-icon>
 						</uui-button>
 					</umb-template-card>
@@ -191,8 +191,8 @@ export class UmbInputTemplateElement extends UUIFormControlMixin(UmbLitElement,
 			<uui-button
 				id="btn-add"
 				look="placeholder"
-				label="${this.localize.term('general_add')}"
-				@click="${this.#openPicker}"></uui-button>
+				label=${this.localize.term('general_choose')}
+				@click=${this.#openPicker}></uui-button>
 		`;
 	}
 

src/packages/tiny-mce/property-editors/toolbar/property-editor-ui-tiny-mce-toolbar-configuration.element.ts

@@ -114,17 +114,17 @@ export class UmbPropertyEditorUITinyMceToolbarConfigurationElement
 
 	override render() {
 		return html`<ul>
-				${repeat(
-					this._toolbarConfig,
-					(v) => v.alias,
+			${repeat(
+				this._toolbarConfig,
+				(v) => v.alias,
 				(v) =>
 					html`<li>
-							<uui-checkbox label=${v.label} value=${v.alias} ?checked=${v.selected} @change=${this.onChange}>
-								<uui-icon .svg=${tinyIconSet?.icons[v.icon ?? 'alignjustify']}></uui-icon>
+						<uui-checkbox label=${v.label} value=${v.alias} ?checked=${v.selected} @change=${this.onChange}>
+							<uui-icon .svg=${tinyIconSet?.icons[v.icon ?? 'alignjustify']}></uui-icon>
 							${v.label}
-							</uui-checkbox>
+						</uui-checkbox>
 					</li>`,
-				)}
+			)}
 		</ul>`;
 	}
 

src/packages/user/user/collection/views/grid/user-grid-collection-view.element.ts

@@ -131,8 +131,7 @@ export class UmbUserGridCollectionViewElement extends UmbLitElement {
 
 		return html`<div class="user-login-time">
 			<umb-localize key="user_lastLogin"></umb-localize>
-			${this.localize.date(user.lastLoginDate)}
-			${formattedTime}
+			${this.localize.date(user.lastLoginDate)} ${formattedTime}
 		</div>`;
 	}