Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/swap to popover container - part 1 #1013

Merged
merged 49 commits into from
Dec 5, 2023

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Nov 22, 2023

Replaces all instances of the old popover element with the new popover-container element
also combines umb-dropdown and umb-button-with-dropdown into umb-dropdown.

Niels:
This PR also updates TypeScript as we needed latest features to be typed, as well it performes a format to match latest.

@nielslyngsoe nielslyngsoe marked this pull request as ready for review November 28, 2023 08:27
@nielslyngsoe nielslyngsoe marked this pull request as draft November 28, 2023 09:09
@JesmoDev JesmoDev changed the title Feature/swap to popover container Feature/swap to popover container - part 1 Nov 30, 2023
@nielslyngsoe nielslyngsoe marked this pull request as ready for review November 30, 2023 10:08
@nielslyngsoe
Copy link
Member

Hi @JesmoDev

Are you using a special build of the uui-popover-container, cause when i run this, it looks like this:
image

@nielslyngsoe nielslyngsoe marked this pull request as draft November 30, 2023 10:43
@JesmoDev
Copy link
Contributor Author

JesmoDev commented Dec 1, 2023

Hi @JesmoDev

Are you using a special build of the uui-popover-container, cause when i run this, it looks like this: image

Not as far I know, just did a fresh node_modules and package-lock install and it still works fine for me

image

@JesmoDev JesmoDev marked this pull request as ready for review December 4, 2023 10:17
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, works well. :) still a few visual things, but we will correct that as we go :-)

@nielslyngsoe nielslyngsoe merged commit ad20d9c into main Dec 5, 2023
6 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/swap-to-popover-container branch December 5, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants