Improvement: Direct usage of selection manager instead of proxy methods #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsrasmussen
changed the title
src/packages/core/modal/common/section-picker/section-picker-modal.element.ts
Show resolved
Hide resolved
nielslyngsoe
deleted the
Improvment/direct-usage-of-selection-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the selection manager public so we can call methods directly on the manager instead of proxying them with methods on the implementing class. This will simplify the interface for that class.
See the tree context interface as an example of how many methods can be removed from the interface:
https://github.com/umbraco/Umbraco.CMS.Backoffice/pull/1030/files#diff-63700e0510ec22c2995269f8338ca4b82d8a0dcb612b06b2dd93e90c621e909aL20
The PR also adds tests for the Selection Manager:
https://github.com/umbraco/Umbraco.CMS.Backoffice/pull/1030/files#diff-6f2e37bb4ffdcac7a21718fccc2817722cfee34cae23b7b6d702f7d775f3a17bR1