Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/layout issues #1037

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Bugfix/layout issues #1037

merged 5 commits into from
Dec 1, 2023

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Nov 30, 2023 •
edited
Loading

  • Fixes some layout issues preventing flexible layouts
  • Fixes the colors of the header tabs
  • Cleans up header to remove functionality that is now already a part of tab group

Note: To get the full effect of these changes, this version or of uui-tab-group is needed: umbraco/Umbraco.UI#677

@JesmoDev JesmoDev marked this pull request as ready for review November 30, 2023 06:57
@JesmoDev JesmoDev marked this pull request as draft November 30, 2023 07:04
@JesmoDev JesmoDev removed the request for review from nielslyngsoe November 30, 2023 07:05
@JesmoDev JesmoDev marked this pull request as ready for review December 1, 2023 04:44
nielslyngsoe
nielslyngsoe approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this clean up the old collapsing, and make it ready for new version of UUI.

@nielslyngsoe nielslyngsoe merged commit 168c444 into main Dec 1, 2023
6 checks passed
@nielslyngsoe nielslyngsoe deleted the bugfix/layout-issues branch December 1, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesmoDev @nielslyngsoe