Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Block Grid Editor — Move between areas and root (A Sorter Controller Fix) #1949

Merged
merged 2 commits into from
May 29, 2024

Conversation

nielslyngsoe
Copy link
Member

This PR fixes an issue where the sorter would get stuck when moving from root to an area or from an area to the root.

As you will notice the PR does not change any code of the Block Grid Editor, but the Sorter as the problem was that the Sorter did not handle if the model changed leaving the active entry data undiscoverable by instance.
Basically because our models are immutable we will get new objects when retrieving an update of our model.
This PR changes so the sorter used latest entry of the model and fixes the issue by that.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe changed the title Fix: Move between areas and root Fix: Block Grid Editor — Move between areas and root (A Sorter Controller Fix) May 29, 2024
@nielslyngsoe nielslyngsoe enabled auto-merge May 29, 2024 10:16
@nielslyngsoe nielslyngsoe merged commit 9b784e4 into main May 29, 2024
6 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/bugfix/block-grid-move-from-to-areas branch May 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants