Bugfix: Document Public Access cancelled server requests #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsrasmussen
changed the title
madsrasmussen
deleted the
v14/bugfix/document-public-access-cancelled-server-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: umbraco/Umbraco-CMS#16548
This PR ensures that the "Public Access"-entity action is wired up. The PR also adds an icon to the document tree item to show when a document is protected.
The member endpoints require access to the member section to work. We have the same limitation in V13. I have decided to hide the "Public Access"-entity access if a user doesn't have access to the member section. Then we prevent the UI from exploding.
What to test:
Types of changes