Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Insert field value overflow #1991

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Jun 10, 2024

Description

Fixes overflow in modal when inserting a field value

Fixes: umbraco/Umbraco-CMS#16491

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@bjarnef
Copy link
Contributor

bjarnef commented Jun 10, 2024

Not sure if wrapping lines is the best solution. The old backoffice used scroll on overflow.
Sometimes it improved readability when code lines don't wrap.

Perhaps the component itself could have wrap property to toggle wrapping lines similar to Text/XML/JSON visualizer in Visual Studio and other IDE.

There is also a discussion here about emhancement of the code snippet https://github.com/umbraco/Umbraco.CMS.Backoffice/discussions/1002

@loivsen
Copy link
Contributor Author

loivsen commented Jun 17, 2024

Not sure if wrapping lines is the best solution. The old backoffice used scroll on overflow. Sometimes it improved readability when code lines don't wrap.

Perhaps the component itself could have wrap property to toggle wrapping lines similar to Text/XML/JSON visualizer in Visual Studio and other IDE.

There is also a discussion here about emhancement of the code snippet #1002

I agree that wrapping text would not be an ideal solution for the code block component. 😊 The component already have a built-in scrollbar for horizontal scrolling, so all I had to tweak was the css within the modal that was nullifying the scrollbar.
I considered to expand the modal from small to medium, that way we can read more of the line and the scrollbar isn't so big, but it didn't quite feel right due to the rest of the fairly little content within the modal. 🤔

@loivsen loivsen requested a review from leekelleher June 17, 2024 08:45
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, the scrollbar appears within the code block. 👍

@leekelleher leekelleher merged commit 66de491 into main Jun 17, 2024
7 checks passed
@leekelleher leekelleher deleted the v14/bugfix/insert-field-value-overflow branch June 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V14-RC5: Overflow in overlay when inserting field value
4 participants