added friendly message to display when there are no other languages t… #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecp
approved these changes
Jun 14, 2024
|
Hi @prjseal , Thanks a lot for this fix, it's much friendlier this way 😁👍 |
|
And a huge H5YR for spotting and solving this issue all during our Codegarden hackathon!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No languages friendly message
Codegarden 24 Hackathon PR
This PR adds a friendly message to the modal when you try to add a fallback language but there aren't any to choose from.
It takes it from looking like this:
To now looking like this:
I also made sure the existing functionality still works when there are languages to choose from: