-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Installer does not take the minimum password length into account #1998
Conversation
I THINK this is now ready to go, but if someone is able to review it I'd be grateful |
this optimizes Lit's update checker so that the template is only re-rendered if the actual number changes, whereas otherwise it would re-render when the object is set again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it slightly so that we optimize for Lit's update checker by extracting the minimum password length into its own state variable. This has the effect that the template is only re-rendered if the actual number changes, whereas otherwise it would re-render when the object is set again.
LGTM.
Thanks @iOvergaard I must admit the architecture of the new Back Office is still a little new to me, but I'm learning :-) |
The password length is not correctly being set on the UI element, this is a hacky fix which forces the validation to fail. I need to refactor this (hopefully with some help)
Fixes umbraco/Umbraco-CMS#16601