Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved example + minor code refactor #2003

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

nielslyngsoe
Copy link
Member

Improved example to actually demonstrate how nested sorter controller can work in a infinite group situation.

Types of changes

As well this does a minor refactor of the Sorter Controller, while thinking about supporting ability to define a Handle Selector, but this is instead created as a task in the backlog.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe merged commit cca3423 into main Jun 19, 2024
6 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/sorter-nested-example branch June 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants