Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Readonly mode for Toggle Property Editor UI #2031

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Feature: Readonly mode for Toggle Property Editor UI #2031

merged 5 commits into from
Jul 29, 2024

Conversation

madsrasmussen
Copy link
Contributor

Description

This PR adds readonly mode to the Toggle Property Editor UI

How to test

  • Add the readonly attribute to the element through developer tools

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@madsrasmussen madsrasmussen marked this pull request as ready for review July 29, 2024 08:31
leekelleher
leekelleher approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, LGTM! 👍

@leekelleher leekelleher merged commit d4fe85d into main Jul 29, 2024
8 checks passed
@leekelleher leekelleher deleted the v14/feature/umb-input-toggle-readonly-mode branch July 29, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

@JesmoDev JesmoDev Awaiting requested review from JesmoDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @leekelleher