Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Force paths to be no longer than 120 characters to support Windows #2033

Merged
merged 41 commits into from
Jul 25, 2024
Merged

Feature: Force paths to be no longer than 120 characters to support Windows #2033

merged 41 commits into from
Jul 25, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jun 24, 2024 •
edited by iOvergaard
Loading

Description

  • Check path length in the dist-cms folder instead of the src folder
  • Check for 120 characters (before 140) -- this is as much as we can handle without breaking stuff and before bundling fix the rest anyway
  • Do not copy d.ts files to the StaticAssets dir as there is no reason to ship them with the CMS and they carry inherently longer file names
  • Only generate declarations on npm run build:for:npm (d.ts files)
  • Make the output of the path length checker script more readable

Fixes umbraco/Umbraco-CMS#16763
Fixes umbraco/Umbraco-CMS#16797

@madsrasmussen madsrasmussen changed the title Chore: Check path length in dist-cms instead of source Chore: Check path length in dist-cms instead of src Jun 24, 2024
@iOvergaard iOvergaard added ignore-for-release Pull requests that will not be included in the automated release notes. internal Changes that do not affect the runtime files, e.g. changes to the build setup labels Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@iOvergaard iOvergaard marked this pull request as ready for review July 3, 2024 14:34
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@iOvergaard iOvergaard changed the title Chore: Check path length in dist-cms instead of src Feature: Force paths to be no longer than 120 characters to support Windows Jul 25, 2024
@iOvergaard iOvergaard added type/feature release/14.2.0 and removed ignore-for-release Pull requests that will not be included in the automated release notes. internal Changes that do not affect the runtime files, e.g. changes to the build setup labels Jul 25, 2024
@iOvergaard iOvergaard self-requested a review July 25, 2024 15:41
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2033.westeurope.1.azurestaticapps.net

@iOvergaard iOvergaard merged commit c27a2c3 into main Jul 25, 2024
8 checks passed
@iOvergaard iOvergaard deleted the v14/chore/check-paths-in-dist-cms branch July 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
release/14.2.0 storybook type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Publish to Azure Web App Long file paths in backoffice files
2 participants
@madsrasmussen @iOvergaard