Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: array state sorting #2067

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Fix: array state sorting #2067

merged 3 commits into from
Jul 2, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jul 1, 2024 •
edited
Loading

We cannot sort a immutable Array, so we must make it mutable first.

Fixes: umbraco/Umbraco-CMS#16462

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

madsrasmussen
madsrasmussen approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielslyngsoe nielslyngsoe merged commit 0c2d4e2 into main Jul 2, 2024
6 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/bugfix/fix-array-state-sorting branch July 2, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console error when picking Block List as property editor
3 participants
@nielslyngsoe @madsrasmussen @iOvergaard